-
Notifications
You must be signed in to change notification settings - Fork 10
Add strategy matrix for toolchain and different OSs with caching #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add strategy matrix for toolchain and different OSs with caching #54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
980a4ed
to
37cd8f8
Compare
…obs-for-all-three-toolchain-channels' of https://github.com/John15321/rust-pip into 37-add-strategy-matrix-to-the-building-and-testing-ci-jobs-for-all-three-toolchain-channels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Not too familiar with CI/CD so I'll leave the review to others. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through what I know, and it seems fine to me. though I haven't gone through CI/CD, so leaving it for other reviewers. 👍
Add strategy matrix for
ubuntu-latest
,windows-latest
,macos-latest
and toolchain matrix forstable
,beta
,nightly
. Additionally some basic caching for the CI jobs has been added and some other misc reformats of the CI jobs