Skip to content

Add strategy matrix for toolchain and different OSs with caching #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

John15321
Copy link
Contributor

@John15321 John15321 commented Sep 3, 2022

Add strategy matrix for ubuntu-latest, windows-latest, macos-latest and toolchain matrix for stable, beta, nightly. Additionally some basic caching for the CI jobs has been added and some other misc reformats of the CI jobs

@John15321 John15321 self-assigned this Sep 4, 2022
@John15321 John15321 added the CI/CD label Sep 4, 2022
@John15321 John15321 added this to the 🚀 Finish the CI/CD setup milestone Sep 4, 2022
@John15321 John15321 changed the title rarararaaaa gagaga gagagagaaaa Add strategy matrix for toolchain and different OSs with caching Sep 4, 2022
@John15321 John15321 marked this pull request as ready for review September 4, 2022 00:12
@John15321 John15321 linked an issue Sep 4, 2022 that may be closed by this pull request
Copy link
Collaborator

@Allstreamer Allstreamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@John15321 John15321 force-pushed the 37-add-strategy-matrix-to-the-building-and-testing-ci-jobs-for-all-three-toolchain-channels branch from 980a4ed to 37cd8f8 Compare September 6, 2022 09:21
…obs-for-all-three-toolchain-channels' of https://github.com/John15321/rust-pip into 37-add-strategy-matrix-to-the-building-and-testing-ci-jobs-for-all-three-toolchain-channels
Copy link
Collaborator

@Allstreamer Allstreamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zephaniahong
Copy link

Not too familiar with CI/CD so I'll leave the review to others.

Copy link
Collaborator

@DevChaudhary78 DevChaudhary78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through what I know, and it seems fine to me. though I haven't gone through CI/CD, so leaving it for other reviewers. 👍

@John15321 John15321 merged commit 23ff86e into develop Sep 8, 2022
@John15321 John15321 deleted the 37-add-strategy-matrix-to-the-building-and-testing-ci-jobs-for-all-three-toolchain-channels branch September 8, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add strategy matrix to the building and testing CI jobs for all three toolchain channels Add macOS and windows testing in the CI/CD piplines
4 participants